Merge pull request #22 from harvard-library/dsi-development

Card #50 - modify Language facet value

app/controllers/catalog_controller.rb

@@ -74,8 +74,8 @@ class CatalogController < ApplicationController
 
  # Facets
  config.add_facet_field 'originDate', label: 'Date Range', range: true, maxlength: 4
- config.add_facet_field 'resourceType', label: 'Type', single: true, limit: 10, :helper_method => 'get_resource_type_translation'
- config.add_facet_field 'language', label: 'Languages', single: true, limit: 10
+ config.add_facet_field 'resourceType', label: 'Type', single: true, limit: 10, :helper_method => 'get_facet_value_translation_for_type'
+ config.add_facet_field 'language', label: 'Languages', single: true, limit: 10, :helper_method => 'get_facet_value_translation_for_languages'
  config.add_facet_field 'repository', label: 'Repository', single: true, limit: 10
 
 

app/helpers/blacklight/facets_helper_behavior.rb

@@ -244,14 +244,21 @@ def facet_display_value field, item
  end
  end
 
+ def get_facet_value_translation_for_languages *args
+ get_facet_value_translation "languages", args[0]
+ end
+
+ def get_facet_value_translation_for_type *args
+ get_facet_value_translation "type", args[0]
+ end
 
- def get_resource_type_translation *args
- puts args.inspect
- translation_label = args[0].to_s().gsub(' ', '_').gsub(',', '_').gsub('-', '_').gsub('/', '_').gsub('__', '_')
- puts translation_label
- translation = t('blacklight.search.facets.values.' + translation_label)
+ def get_facet_value_translation field_name, field_label
+ translation_label = field_label.to_s().downcase().gsub(/[ ,;\-\/]/, '_').gsub(/__/, '_')
+ #puts translation_label
+ translation = t('blacklight.search.facets.facet_values_' + field_name + '.' + translation_label, :default => '')
+
  if translation == ''
- translation = args[0]
+ translation = field_label
  end
  translation
  end

config/locales/blacklight.en.yml

@@ -13,15 +13,19 @@ en:
  facets:
  title: 'Limit Your Search'
  more_html: 'More <span class="sr-only">%{field_name}</span> <span class="fa fa-angle-right"></span>'
- values:
+ facet_values_type:
  cartographic: 'Maps'
  mixed_material: 'Archival material'
  moving_image: 'Video'
+ notated_music: 'Notated music'
  software_multimedia: 'Multimedia'
  sound_recording_musical: 'Audio - music'
  sound_recording_nonmusical: 'Audio - non-music'
  still_image: 'Image'
+ text: 'Text'
  three_dimensional_object: '3D Object'
+ facet_values_languages:
+ no_linguistic_content_not_applicable: 'No language provided'
  filters:
  search_term: 'Search term'
  pagination_info:

release.txt

@@ -1,4 +1,5 @@
 6.20.0-lts-4 PP/MC/ED
+-- Modified Language facet value to "No language provided"
 -- Updated placeholder and masonry icons
 -- Truncate Subjects metadata after 3 lines
 -- Item thumbnails focus indicator on hover (Accessibility)