Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate sign-up views into their own module #3610

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

cmsetzer
Copy link
Contributor

@cmsetzer cmsetzer commented Oct 4, 2024

Following on @rebeccacremona's work in #3607, this breaks the sign-up views off of user_management.py and puts them into their own module, user_sign_up.py.

There are some functions such as approve_pending_registrar that fall somewhere in between "user management" and "sign-up" in terms of functionality; in such cases, I did my best to minimize import dependencies between modules and keep functions alongside their associated views. Open to feedback though.

@cmsetzer cmsetzer requested a review from a team as a code owner October 4, 2024 01:53
@cmsetzer cmsetzer requested review from matteocargnelutti and rebeccacremona and removed request for a team and matteocargnelutti October 4, 2024 01:53
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (02beba5) to head (f7a73ce).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
perma_web/perma/views/user_sign_up.py 95.26% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3610      +/-   ##
===========================================
+ Coverage    69.20%   69.26%   +0.05%     
===========================================
  Files           53       54       +1     
  Lines         7193     7207      +14     
===========================================
+ Hits          4978     4992      +14     
  Misses        2215     2215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rebeccacremona rebeccacremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Into it!

@cmsetzer cmsetzer merged commit b44a0e2 into harvard-lil:develop Oct 4, 2024
2 checks passed
@cmsetzer cmsetzer deleted the user-sign-up-module branch October 4, 2024 15:33
cmsetzer added a commit to cmsetzer/perma that referenced this pull request Oct 4, 2024
Copy link

sentry-io bot commented Oct 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SMTPServerDisconnected: please run connect() first /sign-up/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants