Convert settings views' tests to pytest syntax #3613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all the tests for the settings views, extracted in #3607, to pytest syntax, and switches them to use pytest fixtures instead of JSON fixtures + mocks.
I don't love some of these tests, but I resisted the urge to change them too much: not the goal of this exercise 🤣.
As before, I think only a lightweight review is in order, and let it be on my head if I messed things up in the conversion: not worth anybody's time to study this.
But, a quick buzz through for code style would be appreciated. Do you see anything that offends sensibilities?