Prevent sass deprecation warnings #3615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bit of housekeeping, this prevents deprecation notices during sass compile from using slash as a division operator and using minus-sign-variable without parens.
As suggested by sass, I did
and then went and cleaned up the changes.
Fun fact for division: these are mostly in an early section of the css that must have an interesting story behind it. There's a bunch of stuff like
.col-sm-10by3 { width: 100% * math.div(5, 18); // 10/3 width }
that looks like it was copied from bootstrap, modified, and in some cases not currently used. I didn't go down the rabbit hole of figuring out what should be imported from bootstrap or deleted.Fun fact for unary negation: I believe the rules
strict-unary
updated were in fact not operating as intended, which of course is why they started printing warnings about them. There's stuff in here likemargin: 0 -$grid $double -$grid;
which apparently would have been parsed asmargin: (0-$grid) ($double-$grid)
, which I'm sure can't be what the author meant. I arbitrarily chose to have these do what they read like rather than how browsers have been interpreting them, by updating tomargin: 0 (-$grid) $double (-$grid);
, so at least the authorial intent will be visible if anyone ever goes back to revise. I looked at the affected elements (the single-link menu dropdown, and the link browser item-containers) and they look fine to me.