feat(crd): update vm-dhcp-controller crd manifests #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add declarative validations and some additional fields to support agent upgrades Signed-off-by: Zespre Chang <zespre.chang@suse.com>
|
do we even need to publish the crds? the controller already has the crds packaged as bindata and will apply the manifests at upgrade. |
|
@ibrokethecloud Thanks for bringing up the question. This is for the convenience of other projects that depend on the CRDs to develop and test more easily, just in case. cc @bk201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add declarative validations and some additional fields to support agent upgrades
Ref: