Enhancement: Add IP mask field to Network Panel #897
+125
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IP mask field to provide better network configuration options: - Display calculated netmask when CIDR notation is used - Allow manual netmask input for non-CIDR IP addresses Signed-off-by: Chris Chiu <chris.chiu@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IP mask field to provide better network configuration options:
Problem:
/ or CIDR.Allow users to specify the address as either
Solution:
Display calculated netmask when CIDR notation is used. And validate the netmask input for non-CIDR IP addresses
Related Issue:
harvester/harvester#6295
Test plan:
IPv4 MaskfieldIPv4 Addressfield and check if the netmask generated correctly in theIPv4 Maskfield