[BUG] Automatic VM volume type (cd-rom/disk) based on image type only works for first disk

[tserong]

Describe the bug
When creating a new VM, on the Volumes tab, if you select an ISO Image, the image Type is automatically set to cd-rom, and the Bus to SATA:

If I change the image to something else (not an ISO), the Type changes to disk and the Bus to VirtIO. This automatic update only applies to the first disk. If I add a second disk and select an ISO image, the type remains disk and the bus VirtIO:

I'm at a loss as to understand why we'd only want this automatic disk type and bus setting to happen for the first disk. It should apply for any disk.

(Apologies for missing highlighting the bus on the screenshots)

To Reproduce
Steps to reproduce the behavior:

1. Go to Virtual Machines and click Create.
2. Go to the Volumes tab and add two VM images.
3. Observe that if you select an ISO or non-ISO image for the first disk, the type and bus update as expected.
4. Observe that this type and bus update does not happen for the second disk.

Expected behavior
The type should change to cd-rom and the bus to SATA for any disk with an ISO image (not just the first disk)

Additional context
This should fix it:

--- a/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/vmImage.vue
+++ b/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/vmImage.vue
@@ -141,14 +141,12 @@ export default {
     onImageChange() {
       const imageResource = this.$store.getters['harvester/all'](HCI.IMAGE)?.find( I => this.value.image === I.id);
 
-      if (this.idx === 0) {
-        if (/iso$/i.test(imageResource?.imageSuffix)) {
-          this.$set(this.value, 'type', 'cd-rom');
-          this.$set(this.value, 'bus', 'sata');
-        } else {
-          this.$set(this.value, 'type', 'disk');
-          this.$set(this.value, 'bus', 'virtio');
-        }
+      if (/iso$/i.test(imageResource?.imageSuffix)) {
+        this.$set(this.value, 'type', 'cd-rom');
+        this.$set(this.value, 'bus', 'sata');
+      } else {
+        this.$set(this.value, 'type', 'disk');
+        this.$set(this.value, 'bus', 'virtio');
       }
 
       this.update();

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• [ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at: [BUG] Automatic VM volume type (cd-rom/disk) based on image type only works for first disk #5142 (comment) (i.e. in the description of this bug)

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at: Manually set the disk type and bus

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at: Take image virtual size into account when creating VMs dashboard#976

  • Does the PR include the explanation for the fix or the feature?

  • [ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• [ ] If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• [ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#1290

[irishgordo]

Thanks for this fix @tserong 😄 👍
This looks great in Version: v1.4.0-dev-20240830

Opened up 6540 to track an un-expected behavior I saw w/ VM creation default disk-sizes.

So I'll go ahead and close this out 👍 😄