Fix non-exited while loop in teardown #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2025
lanfon72
reviewed
Feb 26, 2025
| @@ -1065,7 +1067,7 @@ def test_verify_rke2_version(self, api_client, host_shell): | |||
| "kubeletVersion", "") == except_rke2_version, ( | |||
| "rke2 version is not correct") | |||
|
|
|||
| @pytest.mark.dependency(depends=["any_nodes_upgrade"]) | |||
| # @pytest.mark.dependency(depends=["any_nodes_upgrade"]) | |||
There was a problem hiding this comment.
Is there a reason to mark it?
There was a problem hiding this comment.
yeh, I forgot to remove the comment for testing.
Uncommented, thank you.
albinsun
force-pushed
the
fix_cluster_network_teardown
branch
from
2a0fe17 to
38d9e8c
Compare
lanfon72
approved these changes
Feb 26, 2025
khushboo-rancher
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
v1/apps.deploymentsandapps.controllerrevisionsto get app image instead of previousv1/catalog.cattle.io.apps.Special notes for your reviewer:
Verifed
Additional documentation or context
v1/catalog.cattle.io.appsv1/apps.deployments