Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [apiclient] fix default version bug #991

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

lanfon72
Copy link
Member

ref to pypa/packaging#321

LegacyVersion is removed after packaging: 22.0 (the lib is using by pkg_resources), then the parse_version will raise execpetion rather than return a LegacyVersion, so change the default version value to 0.0.0

@lanfon72 lanfon72 requested a review from a team November 23, 2023 19:25
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanfon72 lanfon72 merged commit 2ea46ff into harvester:main Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants