Don't winnow results when search is empty #1226
Conversation
|
One thing I just noticed is that if you click outside the Chosen select, it clears the search. However, if you hit ESC it doesn't clear the search. We can probably handle that in another PR. |
|
@pfiller I've fixed the highlighting now. There is still two cases where it is unnecessarily winnowing.
The problem seems to be that we want to reset the dropdown AND clear the highlighting whenever Chosen is closed. However, these are in two different places. Overall, this change improves performance for users who predominantly use the mouse to open and choose an item. |
| @@ -22,6 +22,7 @@ class Chosen extends AbstractChosen | |||
| @form_field_jq = $ @form_field | |||
| @current_selectedIndex = @form_field.selectedIndex | |||
| @is_rtl = @form_field_jq.hasClass "chzn-rtl" | |||
| @previousSearchText = "" | |||
There was a problem hiding this comment.
shouldn't this be set in the parent constructor instead ?
|
Memoization for the win! This seems like a good start to me. We need about 500 more of these performance improvements to make Chosen hum. I'd like to do a little more click testing tomorrow, but I think this is probably a +1 |
|
@kenearley I fixed a small issue where the highlight wasn't being applied when opening Chosen up if the search wasn't running. I've found another issue where option groups aren't showing and that one seems more complicated. Down the rabbit hole we go... To recreate
|
|
@kenearley With #1339 landing, I don't think this is necessary any longer. Chosen's winnow method is super fast now and I'd rather not have another state tracking variable if we don't have a strong need. If you disagree, feel free to merge master (it's not a clean merge) and re-open. |
@pfiller Here's a better (working) solution to the winnow_results performance. It no longer winnows when first opening the select.
Before change (5000 items)
After change
Note: The big numbers in the second screenshot represent actual searching. The rest are just opening the select.