Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chosen 1.0 #1412

Merged
merged 7 commits into from
Jul 30, 2013
Merged

Chosen 1.0 #1412

merged 7 commits into from
Jul 30, 2013

Conversation

pfiller
Copy link
Contributor

@pfiller pfiller commented Jul 26, 2013

@harvesthq/chosen-developers

Carrying over our discussed in #1405. Anything that will make Chosen "1.0 ready" should get merged into the chosen-1.0 branch first. I've already included the name changes (lizt and chzn are gone here).

@tjschuck
Copy link
Member

Franz is displeased.

@pfiller
Copy link
Contributor Author

pfiller commented Jul 26, 2013

Eh, he seems cool with it.

@stof
Copy link
Collaborator

stof commented Jul 26, 2013

As the chzn-done class is not used anymore by the jQuery plugin to identify elements with chosen applied, shouldn't we remove it entirely instead of replacing it with chosen-done ?
We kept it in the PR refactoring the jquery plugin to avoid breaking stuff for people who may rely on this class, but renaming it would break it for them anyway so it would be the right time to clean it

@kenearley
Copy link

I agree with @stof.

@koenpunt
Copy link
Collaborator

I'd agree with removing the class.

@koenpunt koenpunt mentioned this pull request Jul 27, 2013
@pfiller
Copy link
Contributor Author

pfiller commented Jul 29, 2013

I've removed the chosen-done class. Good call, @stof.

pfiller added a commit that referenced this pull request Jul 30, 2013
@pfiller pfiller merged commit 0b03035 into master Jul 30, 2013
@pfiller pfiller deleted the chosen-1.0 branch July 30, 2013 16:05
Amorymeltzer added a commit to Amorymeltzer/delsort that referenced this pull request Jun 2, 2019
chzn- prefix was renamed to chosen- back in 2013 (harvesthq/chosen#1412).  Items appear the same without this line, although have `text-align` as `start`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants