Right to Left initialization option #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made a couple of small tweaks to the docs and grammar. |
|
Thanks @tjschuck |
|
👍 |
| @@ -18,6 +18,7 @@ class AbstractChosen | |||
| @mouse_on_container = false | |||
| @results_showing = false | |||
| @result_highlighted = null | |||
| @is_rtl = @options.rtl || /\bchosen-rtl\b/.test(@form_field.className) || false | |||
There was a problem hiding this comment.
.test returns true or false so there's no need for the final || false.
|
Is this still relevant? We should just close this if it's stale. |
|
Why would it be irrelevant? |
koenpunt
force-pushed
the
koenpunt-rtl-option
branch
from
ea0e4f0
to
7310b86
Compare
…n of classname approach.
|
Why did this linger for so long? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers I've pulled in @koenpunt's branch and updated the docs to note deprecation of the classname approach.