Fixes focus highlighting on disabled chosen select boxes (Chrome, Windows) #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @oriondean. This looks good to me and I think I'd like to get it merged before this PR sits around for the full year. |
pfiller
added a commit
that referenced
this pull request
Mar 28, 2015
Fixes focus highlighting on disabled Chosen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on a disabled chosen element focuses it and shows a highlight border around the element.
You can view an example here: http://jsfiddle.net/HpACF/
This is caused by tabindex -1 being added to the chosen-single anchor tag.
Any anchor tag without an href attribute cannot be tabbed to or focused into.
By adding tabindex -1 to the anchor tag, it means that it can not be focused into via tabbing.
My fix removes this tabindex -1 attribute from the anchor tag.
This means that a disabled chosen select box is no longer focusable when disabled, removing the highlight border when clicking into the chosen element.