-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessible <select>
elem solution
#2013
Open
alademann
wants to merge
2
commits into
harvesthq:main
Choose a base branch
from
alademann:screen-reader-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sass/chosen.scss
Outdated
@@ -417,3 +417,15 @@ $chosen-sprite-retina: image-url('chosen-sprite@2x.png') !default; | |||
} | |||
} | |||
/* @end */ | |||
|
|||
/* @group Accessibility helpers */ | |||
.sr-only { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please prefix the class with chosen-
to avoid conflicts with other libraries.
Good call @stof - done. |
There is a PR starting to add accessibility to Chosen: #2047 I guess both PRs should not be merged, right ? What do you think about the accessibility PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking the "deep dive" into making the Chosen markup accessible, my proposed solution takes a much simpler approach centered around the principles of progressive enhancement.
Instead of using
display: none
on the converted<select>
element, I have used a utility CSS class that follows accepted best practices for hiding content so that it is accessible to screen readers. In addition to this, I have added anaria-hidden=true
to the<div class="chosen-container">
element.The combination of these two simple changes makes for an accessible solution because:
<select>
element will be the control used by screen readers<div class="chosen-container">
element will be ignored by screen readersObviously a fully-accessible
listbox
solution would be ideal - but IMO, this change will go a long way to making existing Chosen implementations accessible today.