-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows searching for & and other special characters #2157
Conversation
I have the same issue, but we're using the prototype version of Chosen. |
@lode Can you cherry-pick @rkhmelichek's commit over to your PR so this is just one PR? |
@tjschuck, I'll do. By the way, I don't think it was added by #1339, it was just moved, see https://github.com/harvesthq/chosen/pull/1339/files#diff-c82fb80b20c6f4dcdec5a08a57059c30L409. As far as I know it was added in aed8ba8. |
@tjschuck, how do you prefer the merges to be done? By the way, if you feel that this creates xss trouble again, please let me know. |
Rebasing should be fine. I can't give the +1 on the code change -- I'm mostly just a babysitter for Chosen, managing/triaging issues. One of the @harvesthq/chosen-developers will have to assess whether this will cause XSS or other issues. |
e.g. & should not be converted to &
This allows me to search for special characters like ampersand in select boxes. I have a client which has trouble without this as they have large selects and a few options are only findable via ampersands. (i.e.
a&b
will not be found easily asa
andb
are far too common).I don't know if this might break something (why the
html()
was needed), but for me it seems to work.