Update bower-chosen to use unminified versions #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though Bower itself is unopinionated about whcih version is included, the consensus amongst common libraries is to include the unminified versions of source files. People probably use build systems to minify those files for production (I hope).
| @@ -37,7 +37,7 @@ | |||
| ], | |||
| "bowerJSON":{ | |||
| "main": [ | |||
| "chosen.jquery.min.js", | |||
| "chosen.jquery.js", | |||
| "chosen.css", | |||
There was a problem hiding this comment.
No need to change the css since it was already referencing the full version (even though we were packaging the minified css file).
pfiller
added a commit
that referenced
this pull request
Apr 7, 2015
Update bower-chosen to use unminified versions
|
Shouldn't both the minified and unminified versions be in there? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
Though Bower itself is unopinionated about whcih version is included, the consensus amongst common libraries is to include the unminified versions of source files. People probably use build systems to minify those files for production (I hope).
Fixes #2298 and #2288