-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install latest git to support version sorting #2528
Conversation
also set sudo to false to enable docker builds, which are way faster
For reference; Precise: https://travis-ci.org/harvesthq/chosen/builds/107869514 |
addons: | ||
apt: | ||
sources: | ||
- git-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure it can just be git
by itself and not reference git-core
anymore. git-core
was a transitional name because of goofy reasons — it should now just be a dummy package that points to git
as its only dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git-core
is the only one on the whitelist, so maybe it's true for regular apt, but not with the docker addons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And these are sources, not packages, the package is simply git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. It looks like that whitelist entry was only added 18 days ago in travis-ci/apt-source-safelist#225. This is fine with me then, because I don't feel like PR'ing the addition of git
to the whitelist 😜
Coooooooooool with me. Thanks @koenpunt! |
install latest git to support version sorting
Followup on #2527
This enables docker based builds, and updates Git to the latest stable version, to support sorting based on version instead of alphabetically.