Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fixed - prevent clicking on hidden results scrollbar in IE #2886

Closed
wants to merge 0 commits into from

Conversation

cbarber
Copy link

@cbarber cbarber commented Sep 20, 2017

Resolve IE issue where clicking on the hidden results scrollbar triggers the chosen select to display.

Steps:

  • Create chosen select with enough results to show a scrollbar in the results div
  • Focus and blur the chosen select at least once. Note the location of the scrollbar
  • Click on the location of where scrollbar is (albeit hidden). Chosen select will display

Example gif:
https://imgur.com/a/pDhBu

The fix is to exclude "chosen-results" from the mousedown event. Does not seem to have side effects.

@tjschuck
Copy link
Member

Weird! Thanks for the GIF — that shows the issue perfectly.

What browser, browser version, OS, and OS version are you using?

@cbarber
Copy link
Author

cbarber commented Sep 20, 2017

Oops. Sorry I forgot to include those details. Windows 10 - Internet Explorer 11.608.15063.0

@cbarber
Copy link
Author

cbarber commented Sep 25, 2017

I discovered that any form field beneath the drop down was not receiving mouse click event where the scrollbar is located. I felt like adding more logic to the mouse down event method was the wrong the approach. I've updated the pull request to hide the scrollbar (IE only) when the drop down is deactived and show it when its activated. I feel like this is a safer way to handle the quirk.

@tjschuck
Copy link
Member

tjschuck commented Oct 2, 2017

@cbarber Can you squash this down to one commit? Instructions here.

@cbarber
Copy link
Author

cbarber commented Nov 13, 2017

@tjschuck Sorry I missed your message. Pull request has been updated.

@tjschuck
Copy link
Member

@cbarber Thanks!

@harvesthq/chosen-developers One of y'all wanna take a peek and review?

Possible red herring, but: this change is happening around some of those clip attributes that are apparently an issue — any chance this would actually be fixed without vendor-prefixery via the clip removal PR?

@cbarber
Copy link
Author

cbarber commented Mar 14, 2018

Oops. I rebased to resolve the conflicts and it looks like a forced push to my fork closed the PR. When I was resolving the conflict I did notice that the clip css style that was related to the original problem had been switched to display: none. I don't have IE available right now to see if this resolves this but should be able to check in the next day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants