Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

describe => it #2899

Closed
wants to merge 2 commits into from
Closed

describe => it #2899

wants to merge 2 commits into from

Conversation

koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Oct 3, 2017

The incorrect keyword was being used.

@Mikk3lRo
Copy link
Contributor

Mikk3lRo commented Oct 3, 2017

Uhh... Actually describe is not incorrect here...?

The it's come below - describe is like a headline for several tests related to the boundary-detection...

@koenpunt
Copy link
Collaborator Author

koenpunt commented Oct 3, 2017

@Mikk3lRo I guess you're right, I missed the it below.

But I still then think these tests could be written more readable, and then probably then also become less error prone.

@koenpunt koenpunt closed this Oct 3, 2017
@tjschuck tjschuck deleted the koenpunt-patch-1 branch October 3, 2017 16:24
@Mikk3lRo Mikk3lRo mentioned this pull request Oct 6, 2017
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koenpunt @Mikk3lRo @stof