Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use CDN for jQuery and Prototype. #2940

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Conversation

adunkman
Copy link
Contributor

/cc @harvesthq/chosen-developers as an FYI, but I’m just going to merge this to get the build fixed.

We’re having issues in CI loading these files from ajax.googleapis.com, so let’s load them locally instead of from a CDN. Here’s an example of the build failure:

Running "jasmine:jquery" (jasmine) task
Testing Jasmine specs via PhantomJS
>> ReferenceError: Can't find variable: jQuery at
>> public/chosen.jquery.js:606
 Basic setup
   - should add chosen to jQuery object......X
     ReferenceError: Can't find variable: jQuery in file:///home/travis/build/harvesthq/chosen/spec/public/jquery_specs.js (line 4) (1)
   - should create very basic chosen......X
     ReferenceError: Can't find variable: $ in file:///home/travis/build/harvesthq/chosen/spec/public/jquery_specs.js (line 9) (1)
…

We’re having issues in CI loading these files, so let’s load them locally instead of from a CDN to see if it fixes it.
@adunkman adunkman merged commit d9a91ae into master Jan 19, 2018
@adunkman adunkman deleted the fix-ci-jquery-issues branch January 19, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant