Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made logo white on dark mode #397

Merged
merged 4 commits into from
Jan 16, 2024
Merged

feat: made logo white on dark mode #397

merged 4 commits into from
Jan 16, 2024

Conversation

isaiahthedev
Copy link
Contributor

Description

This change resolves issue #394 make the logo white on dark mode

screenshots

Screenshot from 2024-01-15 21-10-04(1)

@isaiahthedev isaiahthedev changed the title Made logo white on dark mode feat: made logo white on dark mode Jan 16, 2024
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@NoamGaash NoamGaash linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing!
however - have you verified all lines of code are necessary? I believe some lines can be removed

isaiahthedev and others added 3 commits January 16, 2024 13:08
commit suggestion
Update src/layout/sidebar/sidebar.scss

Co-authored-by: Noam Gaash <noam.gaash@gmail.com>
Co-authored-by: Noam Gaash <noam.gaash@gmail.com>
@isaiahthedev
Copy link
Contributor Author

Thanks for the feedback, very helpful since I'm new to git/github. I'm hoping everything is good to go now 💯

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@NoamGaash NoamGaash merged commit 43a232c into hasadna:main Jan 16, 2024
16 checks passed
@isaiahthedev isaiahthedev deleted the darkmode-fix branch January 16, 2024 21:58
VSciFlight added a commit to VSciFlight/open-bus-map-search that referenced this pull request Jan 30, 2024


* 'main' of https://github.com/VSciFlight/open-bus-map-search: (94 commits)
  chore: lint css (hasadna#442)
  style: Ensure minimum width for ArrivalByTimeChart  (hasadna#433)
  fix: Remove unknown data (hasadna#438)
  chore: Revert "chore: add temporary route for the version release event (hasadna#382)" (hasadna#441)
  ci: upgrade linter (hasadna#439)
  fix: scrollbar color on dark mode (hasadna#431)
  fix: Fix for issue hasadna#428 unable to run project locally (hasadna#430)
  chore: Adding tnufa to dropdown in dashboard hasadna#423 (hasadna#429)
  chore(main): release 1.0.0 (hasadna#326)
  fix: make input labels visible at dark mode (hasadna#424)
  fix: make top input label visible at singleLine page (hasadna#420)
  chore: add i18n type safety (hasadna#419)
  feat: add home-page files and temp route (hasadna#403)
  feat: finish bug report form creation (hasadna#411)
  feat: Translation of the remaining untranslated text on the About page (hasadna#399)
  test: add SinglelinePage tests (hasadna#393)
  feat: made logo white on dark mode (hasadna#397)
  feat: date picker component show invalid dates warning (hasadna#398)
  chore: hide bug report form (hasadna#388)
  docs: fixed a dead link in README.md (hasadna#396)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make the logo white on dark mode
3 participants