-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: made logo white on dark mode #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing!
however - have you verified all lines of code are necessary? I believe some lines can be removed
commit suggestion Update src/layout/sidebar/sidebar.scss Co-authored-by: Noam Gaash <noam.gaash@gmail.com>
Co-authored-by: Noam Gaash <noam.gaash@gmail.com>
Thanks for the feedback, very helpful since I'm new to git/github. I'm hoping everything is good to go now 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks!
* 'main' of https://github.com/VSciFlight/open-bus-map-search: (94 commits) chore: lint css (hasadna#442) style: Ensure minimum width for ArrivalByTimeChart (hasadna#433) fix: Remove unknown data (hasadna#438) chore: Revert "chore: add temporary route for the version release event (hasadna#382)" (hasadna#441) ci: upgrade linter (hasadna#439) fix: scrollbar color on dark mode (hasadna#431) fix: Fix for issue hasadna#428 unable to run project locally (hasadna#430) chore: Adding tnufa to dropdown in dashboard hasadna#423 (hasadna#429) chore(main): release 1.0.0 (hasadna#326) fix: make input labels visible at dark mode (hasadna#424) fix: make top input label visible at singleLine page (hasadna#420) chore: add i18n type safety (hasadna#419) feat: add home-page files and temp route (hasadna#403) feat: finish bug report form creation (hasadna#411) feat: Translation of the remaining untranslated text on the About page (hasadna#399) test: add SinglelinePage tests (hasadna#393) feat: made logo white on dark mode (hasadna#397) feat: date picker component show invalid dates warning (hasadna#398) chore: hide bug report form (hasadna#388) docs: fixed a dead link in README.md (hasadna#396) ...
Description
This change resolves issue #394 make the logo white on dark mode
screenshots