fix: Remove unknown data #438
Conversation
|
https://open-bus-stride-api.hasadna.org.il/gtfs_agencies/list I don't see any agency with that ID in the gtfs data |
|
If you will log the data recieved at the useGroupby hook you will see there is a alot of operator_ref with the value of 22. Maybe it's some old data in the postgress that was not updated or deleted in some way |
|
It worth an exploration using the Swagger.
I've tried to run this query, and seems like it takes forever |
|
ok it worked - seems like we get data from the TLV light rail (Dankal)! |
src/api/groupByService.ts
Outdated
| (agency) => agency.agency_id === String(dataRecord.operator_ref), | ||
| ), | ||
| })) | ||
| //NOTE: the problem comes from agencyList number 22 is not found. need to add the agency or remove it from the DB |
There was a problem hiding this comment.
| //NOTE: the problem comes from agencyList number 22 is not found. need to add the agency or remove it from the DB | |
| // should filter operator 22 (which is the Dankal TLV light train) |
|
no problem, I changed the comment to what you specified. happy to contribute :) |
* 'main' of https://github.com/VSciFlight/open-bus-map-search: (94 commits) chore: lint css (hasadna#442) style: Ensure minimum width for ArrivalByTimeChart (hasadna#433) fix: Remove unknown data (hasadna#438) chore: Revert "chore: add temporary route for the version release event (hasadna#382)" (hasadna#441) ci: upgrade linter (hasadna#439) fix: scrollbar color on dark mode (hasadna#431) fix: Fix for issue hasadna#428 unable to run project locally (hasadna#430) chore: Adding tnufa to dropdown in dashboard hasadna#423 (hasadna#429) chore(main): release 1.0.0 (hasadna#326) fix: make input labels visible at dark mode (hasadna#424) fix: make top input label visible at singleLine page (hasadna#420) chore: add i18n type safety (hasadna#419) feat: add home-page files and temp route (hasadna#403) feat: finish bug report form creation (hasadna#411) feat: Translation of the remaining untranslated text on the About page (hasadna#399) test: add SinglelinePage tests (hasadna#393) feat: made logo white on dark mode (hasadna#397) feat: date picker component show invalid dates warning (hasadna#398) chore: hide bug report form (hasadna#388) docs: fixed a dead link in README.md (hasadna#396) ...
Description
fixed #339 problem on frontend side where there were "unknown" bus provider
need to check the agency list and add a new agency to be like the DB
screenshots