Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

קיום נסיעות #856

Closed
OpenBusBot opened this issue Jul 23, 2024 · 4 comments
Closed

קיום נסיעות #856

OpenBusBot opened this issue Jul 23, 2024 · 4 comments
Labels
REPORTED-BY-USER

Comments

@OpenBusBot
Copy link
Collaborator

Contact Name: גד פישבך
Contact Email: gad@fishbach.co.il
Description:
לא ברור לי אם מחקתם את המפעיל של אגד תעבורה אז מדוע הוא מופיע בקיום נסיעות?
Environment: דפדפן ווינדוס 11
Expected Behavior:
יראה לי את המפעיל הנכון ולפי זה יהיו לי את הנתונים
Actual Behavior:
לא ברור האם הנסיעות בשם המפעיל שייכות לאלקטרה אפיקים
Reproducibility: כל הזמן
@dorinzrihen
Copy link
Collaborator

@NoamGaash
רק כדי לוודא, אגד תעבורה צריך להימחק רק מ"קיום נסיעות" כי החברה כבר לא רלונטית?

@NoamGaash
Copy link
Member

אני לא בטוח.
אני חושב שפתרון נכון יהיה לשלוף את רשימת המפעילות הרלוונטיות לפי התאריך שהמשתמש בוחר, ולעדכן את הdropdown בהתאם

@TomRytt TomRytt mentioned this issue Aug 27, 2024
Merged
TomRytt added a commit that referenced this issue Aug 30, 2024
@TomRytt
fix: rides history page (#867)
2c9611e 
Fixes issue #856 by adding the required "arrival_time_from" and "arrival_time_to" fields to the gtfs_ride_stops api call.
Changed the previous api call which utilized the gtfsAPI to an axios call directly to the server with the required data since the gtfsAPI whitelisted the required fields mentioned above which caused the api call to fail.

Still requires futher optimizations since the request is very slow and tests need to be written in future issues.
@ofirc77
Copy link
Collaborator

ofirc77 commented Jan 2, 2025

Hi @NoamGaash,
Can you please describe the issue in more details and suggest where I should start investigating?
Thx

@NoamGaash
Copy link
Member

In the dashboard page -
image
I don't see "אגד תעבורה".
image

Maybe it's an old issue that was solved.
I suppose it would be nice to send Gad an email asking if the dashboard is fine now.

@NoamGaash NoamGaash closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
REPORTED-BY-USER
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NoamGaash @dorinzrihen @OpenBusBot @ofirc77