Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css | fix donation modal for mobile devices #942

Closed
NoamGaash opened this issue Nov 23, 2024 · 3 comments · Fixed by #945
Closed

css | fix donation modal for mobile devices #942

NoamGaash opened this issue Nov 23, 2024 · 3 comments · Fixed by #945
Labels
CSS related to the design, without affecting business logic frontend frontend developers issue good first issue Good for newcomers

Comments

@NoamGaash
Copy link
Member

this is how it looks today:
image
@NoamGaash NoamGaash added good first issue Good for newcomers CSS related to the design, without affecting business logic frontend frontend developers issue labels Nov 23, 2024
@NoamGaash NoamGaash mentioned this issue Nov 24, 2024
Merged
@yontank yontank mentioned this issue Nov 24, 2024
Merged
@rivka14
Copy link
Collaborator

rivka14 commented Nov 28, 2024

Hi, I’d like to work on this issue. Could you please assign it to me?

@NoamGaash
Copy link
Member Author

Hi @rivka14 ! Thanks!
Have you seen the #945 pull request that @yontank submitted? Just making sure we won't have collisions.

@NoamGaash NoamGaash linked a pull request Dec 2, 2024 that will close this issue
fix: allow donate modal to dynamically change for devices #945
Merged
@NoamGaash
Copy link
Member Author

Solved in #945 . Thanks @yontank !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS related to the design, without affecting business logic frontend frontend developers issue good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow donate modal to dynamically change for devices hasadna/open-bus-map-search
2 participants
@NoamGaash @rivka14