-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow donate modal to dynamically change for devices #945
Conversation
by the way, I think that we should add some tests to see how things look in English (not just this modal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a great improvement - so please feel free to merge if you feel comfortable with that code, and open another PR if you want to make more progress 🙏
Hey, Sure thing! I thought about creating the tests and then merging, but it's probably gonna take some time since I'm new PlayWright 😢 |
Description
Dynamically changes DonationModal to support (hopefully) most devices,
as written in #942
screenshots