Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot.yml #135

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Create dependabot.yml #135

merged 1 commit into from
Oct 20, 2023

Conversation

NoamGaash
Copy link
Member

@NoamGaash NoamGaash commented Oct 19, 2023

add dependabot

it's a bot that will update our dependencies

@NoamGaash NoamGaash force-pushed the main branch 3 times, most recently from 4467245 to 96ece7d Compare October 19, 2023 09:31
Copy link
Collaborator

@giladfuchs giladfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I follow also this doc
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates

It looks like you follow the example.

I approve it but I don't really have experience with it.
I suggest that check it does not make any error while you push it.

@NoamGaash
Copy link
Member Author

@giladfuchs when you see this message -
image

it means that the PR successfully passed all sanity tests

the goal of the pull requests review is not about finding bugs. It's about keeping our codebase maintainable. If something isn't clear, or you notice anything unusual, that's the place to ask. That's how open source project maintain code quality

@NoamGaash NoamGaash merged commit fa5c482 into main Oct 20, 2023
5 checks passed
@NoamGaash NoamGaash deleted the ci/dependabot branch October 20, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants