Refactoring of the Sidebar component and its styling #138
Conversation
src/App.tsx
Outdated
| @@ -1,6 +1,7 @@ | |||
| import React, { useCallback, useEffect } from 'react' | |||
| import 'antd/dist/antd.min.css' | |||
| import './App.scss' | |||
| import './pages/components/header/sidebar/sidebar.scss' | |||
There was a problem hiding this comment.
please move that import to the SideBar.tsx file
There was a problem hiding this comment.
@NoamGaash
Sorry. My mistake. The mentioned import of sidebar.scss is basically redundant inside App.tsx because it is already imported as part of SideBar.tsx . I removed the redundant one from the App.tsx.
Also, I removed unused import of React from 'react'.
There was a problem hiding this comment.
@AlexKomanov thanks!
regarding React import, it is important:
you should import react to use tags in your tsx files
There was a problem hiding this comment.
Oh. Got it. Fixing my own created issue. :)
|
There is a warning about my branch to be out of date. Should I update my branch? Or it can be merged with its current state? |
|
it's completely fine - it can be merged :) |
Description
This PR contains several changes:
sideber-menuto besidebar-menu-togglesidebarwas added, that contains a componenttsxfile and a correspondingscssfile.The functionality was tested manually and it has the same behavior like before the PR.
This PR closes #133