Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test - use advanced HAR #140

Merged
merged 5 commits into from
Oct 22, 2023
Merged

Test - use advanced HAR #140

merged 5 commits into from
Oct 22, 2023

Conversation

NoamGaash
Copy link
Member

No description provided.

@NoamGaash NoamGaash requested a review from shootermv October 21, 2023 14:18
shootermv
shootermv suggested changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be better to rename example spec page to historicTimeline?

@NoamGaash
Copy link
Member Author

sure, why not.
however, I don't see why it should be merge-blocking. It can easily be done in a separate PR

@shootermv
Copy link
Contributor

shootermv commented Oct 22, 2023 via email

@NoamGaash NoamGaash requested a review from shootermv October 22, 2023 07:38
@NoamGaash NoamGaash merged commit 6c4c3f7 into main Oct 22, 2023
6 checks passed
@NoamGaash NoamGaash deleted the test/use-advanced-har branch October 22, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shootermv shootermv shootermv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoamGaash @shootermv