-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing texts part d#161 #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏
@@ -16,6 +17,7 @@ export function BusToolTip({ position, icon }: BusToolTipProps) { | |||
const [siriRide, setSiriRide] = useState<SiriRideWithRelatedPydanticModel | undefined>() | |||
const [isLoading, setIsLoading] = useState(false) | |||
const [showJson, setShowJson] = useState(false) | |||
const { t } = useTranslation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one can be removed
the bus tooltip can be found in every map, by clicking a bus icon 🚌 |
the only problem now - is unused |
That's because I want to push it to this PR and not the next one:) that is, to remove TEXTS from BusTooltip :) |
so please remove this |
But on hover, there is no tooltip, and I can not see all the information on the bus, in the UI... also, there are the missing translations from the he/en.json: line, time, destination, and more. Anyway, there's a new push to this PR, I removed TEXTS from BusToolTip. |
Sorry, I saw this comment just now, after I made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amabelleS |
Description
Removed from: TimeSelector, StopSelector, RouteSelector, OperatorSelector, MinuteSelector, LineSelector and Profile.
Next, maybe in this PR, I want to remove texts from BusToolTip. but I'm not sure where to find it in the UI, and I need to check because some translations are missing there even in the texts file...