refactor: create MapWithLocationsAndPath component #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
added
bug
|
@NoamGaash |
|
@amabelleS you're right, solved 🙏 😄 |
shootermv
reviewed
Dec 17, 2023
| @@ -1,5 +1,5 @@ | |||
| import type { Meta, StoryObj } from '@storybook/react' | |||
| import { BusToolTip } from './MapLayers/BusToolTip' | |||
| import { BusToolTip } from './map-related/MapLayers/BusToolTip' | |||
There was a problem hiding this comment.
why this import needed here?
There was a problem hiding this comment.
it's not. it should be removed. it's not related to this PR. it should be fixed
There was a problem hiding this comment.
you're the one to blame actually 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactored some components of the
SingleLineMappage to make it easier to deal within the future, and prepare its map component for use in the line profile page
screenshots
irrelevant