Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable preview attempts on fork #306

Merged
merged 1 commit into from
Dec 15, 2023
Merged

ci: disable preview attempts on fork #306

merged 1 commit into from
Dec 15, 2023

Conversation

NoamGaash
Copy link
Member

Description

when secrets.AWS_SECRET_ACCESS_KEY isn't accessible (on forks), the preview job shouldn't be running.

screenshots

irrelevant

@NoamGaash NoamGaash requested a review from yardenmezi December 15, 2023 15:35
@github-actions GitHub Actions
Copy link
Contributor

Preview: https://s3.amazonaws.com/noam-gaash.co.il/7224037759/open-bus/641185a5ee533046ba994d44d992afb2cfd1ce90/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/7224037759/open-bus/641185a5ee533046ba994d44d992afb2cfd1ce90/storybook/index.html

yardenmezi
yardenmezi approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@yardenmezi yardenmezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@NoamGaash NoamGaash merged commit 264653b into main Dec 15, 2023
13 checks passed
@NoamGaash NoamGaash deleted the ci/disable-preview-attemps-on-fork branch December 15, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yardenmezi yardenmezi yardenmezi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoamGaash @yardenmezi