Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): add release-please #320

Merged
merged 2 commits into from
Dec 18, 2023
Merged

chore(main): add release-please #320

merged 2 commits into from
Dec 18, 2023

Conversation

NoamGaash
Copy link
Member

No description provided.

@NoamGaash NoamGaash linked an issue Dec 17, 2023 that may be closed by this pull request
Add release-please #179
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2023 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/7240394552/open-bus/ec101b369f3bea68eeb93e3449187900870e39fe/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/7240394552/open-bus/ec101b369f3bea68eeb93e3449187900870e39fe/storybook/index.html

@amabelleS
Copy link
Collaborator

image

So maybe we should add some link in the CONTRIBUTION.md to docs about those prefixes, like chore:) I needed to google it, to learn the meaning... found this one: https://ec.europa.eu/component-library/v1.15.0/eu/docs/conventions/git/#:~:text=chore%3A%20Changes%20to%20the%20build,libraries%20such%20as%20documentation%20generation

@amabelleS amabelleS mentioned this pull request Dec 18, 2023
Merged
@NoamGaash
Copy link
Member Author

@amabelleS feel free to open an issue about it.

amabelleS
amabelleS approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@amabelleS amabelleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me:)

@NoamGaash NoamGaash merged commit 24a5dad into main Dec 18, 2023
14 checks passed
@NoamGaash NoamGaash deleted the chore/add-release-pleae branch December 18, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amabelleS amabelleS amabelleS approved these changes

@ArkadiK94 ArkadiK94 Awaiting requested review from ArkadiK94

@shootermv shootermv Awaiting requested review from shootermv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release-please
2 participants
@NoamGaash @amabelleS