Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: text suggestion #321

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore: text suggestion #321

merged 1 commit into from
Dec 18, 2023

Conversation

NoamGaash
Copy link
Member

@NoamGaash NoamGaash commented Dec 17, 2023 •
edited
Loading

image

@NoamGaash NoamGaash requested a review from amabelleS December 17, 2023 18:12
@github-actions GitHub Actions
Copy link
Contributor

Preview: https://s3.amazonaws.com/noam-gaash.co.il/7240204953/open-bus/95624af5832e0750d150db6adad5f89d6d1244b5/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/7240204953/open-bus/95624af5832e0750d150db6adad5f89d6d1244b5/storybook/index.html

@NoamGaash NoamGaash changed the title Removed TEXTS from pointTypeToDescription/timeline chore: text suggestion Dec 17, 2023
@NoamGaash NoamGaash mentioned this pull request Dec 17, 2023
Merged
amabelleS
amabelleS approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@amabelleS amabelleS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes, looks great:)
I think it's better than importing "t" to another file.

@NoamGaash NoamGaash merged commit 453486b into removing-texts_part6 Dec 18, 2023
12 checks passed
@NoamGaash NoamGaash deleted the chore/suggestion branch December 18, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amabelleS amabelleS amabelleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoamGaash @amabelleS