fix: input validation alert for start & end date #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amabelleS
changed the title
|
@ArkadiK94 How can I solve this? 
|
NoamGaash
reviewed
Jan 1, 2024
yarn.lock
Outdated
There was a problem hiding this comment.
this file should not be added - we no longer work with yarn
There was a problem hiding this comment.
We should change the error message because it is misleading
Thank you:) sorry for missing that
There was a problem hiding this comment.
this file should not be added - we no longer work with yarn
if I installed all the dependencies with yarn on this project, can I just switch to npm from now?
There was a problem hiding this comment.
I meant the error message in the github actions, from "after removing package-lock.json file" to "after removing yarn.lock file"
However, it is not related to this pr...
NoamGaash
reviewed
Jan 1, 2024
NoamGaash
changed the title
NoamGaash
approved these changes
Jan 2, 2024
|
great job! 💪 |
shootermv
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Showing an alert when the end date is later than the start date - on the dashboard and gaps-pattern pages.
screenshots
related issue: #309 (not closing)