Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DateSelector selector validation message issues #819

Closed
wants to merge 8 commits into from
Closed

fix: DateSelector selector validation message issues #819

wants to merge 8 commits into from

Conversation

YuvalMasada
Copy link
Collaborator

@NoamGaash
I've added 2 short fixes.

  1. For wrong validation message I added a different message for the specific case. The message will pop for min/max, but I think that the max message will never appear( so maybe it would be better to delete it? not 100% sure ).
  2. To make the message re-render when language changed I've extend the useMemo dependency array with t function that should be reassign as the DateSelector component been re-rendered.

dependabot bot and others added 5 commits June 17, 2024 23:24
@dependabot
chore(deps): bump recharts from 2.12.6 to 2.12.7 (#812)
355d42c 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@NoamGaash @zushar
test: front page (#801)
82f43c7 
Co-authored-by: israel zusha rotenberg <100128949+zushar@users.noreply.github.com>
@NoamGaash
ci: preview from fork (#802)
722d4c8
@dependabot
chore(deps): bump styled-components from 6.1.8 to 6.1.11 (#810)
3d495ae 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump @tanstack/react-query from 5.36.0 to 5.45.1 (#811)
f1581d1 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9585077280/open-bus/16/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9585077280/open-bus/16/storybook/index.html

@LiadOvdat5 @NoamGaash
feat: Added complaint button, hidden as an easter egg 'complaint'. (#791
dbbf9a0 
)

Co-authored-by: Noam Gaash <noam.gaash@gmail.com>
Co-authored-by: Noam Gaash <noam.gaash@applitools.com>
@YuvalMasada YuvalMasada changed the title fix of DateSelector selector validation message issues fix: DateSelector selector validation message issues Jun 18, 2024
@allcontributors
docs: add LiadOvdat5 as a contributor for code (#820)
59da665 
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@NoamGaash
Copy link
Member

Hi @YuvalMasada , I believe you want to make this pull request in the opposite direction (into main from fix/DateSelector_selector_validation_message_issues )

@YuvalMasada
Copy link
Collaborator Author

@NoamGaash
Your belief is 100% right :D. Didn't notice.
Will try to fix the fix

@YuvalMasada
Copy link
Collaborator Author

wrong merge direction. Created another PR. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviv1620 aviv1620 Awaiting requested review from aviv1620

@NoamGaash NoamGaash Awaiting requested review from NoamGaash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuvalMasada @NoamGaash @LiadOvdat5