Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporary fix suggestion of the unreadable text in the Donate Modal #908

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

YaelChen
Copy link
Collaborator

@YaelChen YaelChen commented Nov 6, 2024

Description

Only a suggestion for a Temporary fix of the unreadable text in the Donate Modal while in Dark mode.
Until I (or someone else) will be able to change the text color for white in dark mode and black in light mode,
I changed it to blue (as the button) so it will be readable in dark AND light modes.

screenshots

image

@YaelChen YaelChen requested a review from ShayAdler November 6, 2024 19:17
@YaelChen YaelChen requested a review from NoamGaash as a code owner November 6, 2024 19:17
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, nice and creative idea
We could also open an issue for properly fixing the colors, and a visual test for the modal

@@ -24,6 +24,7 @@ const DonateModal: React.FC<DonateModalProps> = ({ isVisible, onClose }) => {
<Modal
open={isVisible}
onClose={onClose}
div style={{ color: '#1498e5' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
div style={{ color: '#1498e5' }}
style={{ color: '#1498e5' }}

@YaelChen YaelChen merged commit 267d1c7 into main Nov 7, 2024
14 checks passed
@YaelChen YaelChen deleted the tempFix_donationChangeColor branch November 7, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants