Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donation modal text dark mode #920

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Conversation

LeoBonjo
Copy link
Collaborator

Extended dark mode theme to be consumable by donation modal components; wrapped in index.tsx in and imported them into DonateModal and DonationButton. The text now correctly changes color to white in dark mode.

Screenshot 2024-11-15 at 3 56 32 PM

@LeoBonjo LeoBonjo requested a review from NoamGaash as a code owner November 15, 2024 20:59
@LeoBonjo LeoBonjo changed the title Fix donation modal text dark mode fix: donation modal text dark mode Nov 15, 2024
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It's working and it improves DataBus, so it can be merged. However there are few suggestions that if you have the time I'd appreciate if you'll consider making the research about so the code will be a little cleaner

Thank you!

src/index.tsx Outdated Show resolved Hide resolved
src/layout/header/DonationButton.tsx Outdated Show resolved Hide resolved
@LeoBonjo LeoBonjo merged commit eb9f605 into main Nov 18, 2024
16 of 17 checks passed
@LeoBonjo LeoBonjo deleted the fix-donation-modal-text-dark-mode branch November 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants