Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: items under trip existence #948

Merged
merged 8 commits into from
Dec 1, 2024
Merged

Conversation

YaelChen
Copy link
Collaborator

Description

  1. added a test for verifying the items inside "trip existance"
  2. fixed the Applitools link under "about" (it suddenly broke for me for some reason.
  • "Choosing params" test was suddenly stuck for me (line 27, no options to choose under "חברה מפעילה"'
    I want to see if it fails in the git checks as well, or it's only happens for me :/

@YaelChen YaelChen requested a review from ReallyLiri November 25, 2024 12:36
@YaelChen YaelChen requested a review from NoamGaash as a code owner November 25, 2024 12:36
Comment on lines 4 to 10
advancedRouteFromHAR('tests/HAR/menu.har', {
updateContent: 'embed',
update: false,
notFound: 'abort',
url: /stride-api/,
matcher: urlMatcher,
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so cool, I'm so glad to see you're using it! How was your experience?
By the way, feel free to record a separate HAR file for this file:

Suggested change
advancedRouteFromHAR('tests/HAR/menu.har', {
updateContent: 'embed',
update: false,
notFound: 'abort',
url: /stride-api/,
matcher: urlMatcher,
})
advancedRouteFromHAR('tests/HAR/tripExistence.har', {
updateContent: 'embed',
update: true,
notFound: 'abort',
url: /stride-api/,
matcher: urlMatcher,
})

After running one test with this version, update can be switched to back false.

(Only if you want to try it out, don't feel obligated)

Copy link
Collaborator Author

@YaelChen YaelChen Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm playing with some trial and error and I've made all sorts of mistakes here :) but I seem to have finally fixed it, and also made a new HAR as you wrote, and pushed it :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so exciting! I'm truly happy to see it. If you have any feedback regarding the developer experience, I would really like to improve things were possible.
The advanced har library is also a project that I maintain so please feel comfortable leaving feedback and ideas and we can improve it as well.

@YaelChen YaelChen merged commit 05ff848 into main Dec 1, 2024
18 checks passed
@YaelChen YaelChen deleted the addTestForTripExistanceItems branch December 1, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants