-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: items under trip existence #948
Conversation
tests/tripExistence.spec.ts
Outdated
advancedRouteFromHAR('tests/HAR/menu.har', { | ||
updateContent: 'embed', | ||
update: false, | ||
notFound: 'abort', | ||
url: /stride-api/, | ||
matcher: urlMatcher, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so cool, I'm so glad to see you're using it! How was your experience?
By the way, feel free to record a separate HAR file for this file:
advancedRouteFromHAR('tests/HAR/menu.har', { | |
updateContent: 'embed', | |
update: false, | |
notFound: 'abort', | |
url: /stride-api/, | |
matcher: urlMatcher, | |
}) | |
advancedRouteFromHAR('tests/HAR/tripExistence.har', { | |
updateContent: 'embed', | |
update: true, | |
notFound: 'abort', | |
url: /stride-api/, | |
matcher: urlMatcher, | |
}) |
After running one test with this version, update
can be switched to back false
.
(Only if you want to try it out, don't feel obligated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm playing with some trial and error and I've made all sorts of mistakes here :) but I seem to have finally fixed it, and also made a new HAR as you wrote, and pushed it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so exciting! I'm truly happy to see it. If you have any feedback regarding the developer experience, I would really like to improve things were possible.
The advanced har library is also a project that I maintain so please feel comfortable leaving feedback and ideas and we can improve it as well.
canceled the "www" change. it failed (though it was demanded localy <shrug>)
Description
I want to see if it fails in the git checks as well, or it's only happens for me :/