fix: changing map language #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofirc77
force-pushed
the
fix_map_translation
branch
2 times, most recently
from
04cfb9e to
176442d
Compare
ofirc77
force-pushed
the
fix_map_translation
branch
2 times, most recently
from
8805fc3 to
a739da1
Compare
|
Hi Ofir! Thanks for making this pull request. Would you run |
ofirc77
force-pushed
the
fix_map_translation
branch
from
a739da1 to
f95061b
Compare
ofirc77
force-pushed
the
fix_map_translation
branch
from
f95061b to
41ab85d
Compare
|
Hi @NoamGaash, Done and code was updated :) |
|
@all-contributors please add @ofirc77 as a code contributor 🏅 |
|
I've put up a pull request to add @ofirc77! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my initial PR for the map translation bug - #950
It currently works only on 'Map by line'. I want to implement that also on 'Time based map' as well.
I think I can improve it mainly with the map URL. I couldn't find better solution at the moment and if we can make the render smoother. I tried to use dependency on the i18n.language but it seems not to work.
Hebrew map:
English map:
