Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing translations #982

Merged
merged 5 commits into from
Dec 19, 2024
Merged

chore: add missing translations #982

merged 5 commits into from
Dec 19, 2024

Conversation

EstherKal
Copy link
Collaborator

@EstherKal EstherKal commented Dec 19, 2024

Title:

Fix translation issues from Hebrew to English

Description:

This PR addresses several issues related to the translation from Hebrew to English:

1. Time Format Fix

  • Corrected the time format to adapt based on the active language:
    • In English, the time is displayed as "AM/PM".
    • In Hebrew, the time is displayed as "אחר הצהריים" or "בבוקר".
  • Used the i18n.language property to dynamically switch the locale in Moment.js for proper time formatting in both languages.

Before:

image

After:

image

2. Title Tag Update

  • Fixed the <title> tag in the document head to correctly update when switching languages.
  • Ensured that the title is properly displayed in English when the site is in English.

Before:

Screenshot 2024-12-19 235110

After:

Screenshot 2024-12-19 235155

3. Header Translation

  • Changed a header that was in Hebrew to English to match the selected language.
  • Ensured consistency across the page by making sure all headers are translated according to the active language.

Before:

Screenshot 2024-12-19 223305

After:

image

@EstherKal EstherKal requested a review from NoamGaash as a code owner December 19, 2024 20:18
@NoamGaash NoamGaash changed the title fixMissingTranslations fix: missing translations Dec 19, 2024
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoamGaash NoamGaash changed the title fix: missing translations chore: missing translations Dec 19, 2024
@NoamGaash NoamGaash changed the title chore: missing translations chore: add missing translations Dec 19, 2024
@EstherKal EstherKal merged commit be5ace0 into main Dec 19, 2024
19 checks passed
@EstherKal EstherKal deleted the fix--missing-translations branch December 19, 2024 23:42
@EstherKal EstherKal self-assigned this Dec 19, 2024
@NoamGaash
Copy link
Member

Thanks!
@all-contributors plaese add @EstherKal as code contributor 🚌 💪

Copy link
Contributor

@NoamGaash

I've put up a pull request to add @EstherKal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants