Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for getting to research page with an easter egg #987

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

YaelChen
Copy link
Collaborator

Description

After the page loads, type "geek" and get the research page.

@YaelChen YaelChen requested a review from NoamGaash as a code owner December 23, 2024 16:20
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really cool! But focusing on Easter eggs is less important - that's an internal feature so breaking it is less of a concern

@YaelChen
Copy link
Collaborator Author

Sure, I was investigating a bit, as I wondered why there isn't data in the Actual rides section
image

And if there's more important stuff you think should be done, let me know :)

@YaelChen YaelChen merged commit 3cd155b into main Dec 24, 2024
16 of 17 checks passed
@YaelChen YaelChen deleted the addTestFoResearch branch December 24, 2024 07:36
@NoamGaash
Copy link
Member

NoamGaash commented Dec 24, 2024

Thanks!
Indeed, there's a bug with the actual rides - I'm not sure where it's coming from, but seems like the actual rides miss some columns so it doesn't appear in the dashboard... I hope someone will solve it.
Regaring testing - I think there is little to no coverage of the bus tooltip and the youtube modals. Also, I think it could be nice to add visual assertions for regions - eyes.check('step name', Target.region(page.getByRole(...))).
Also, other nice contribution would improving the backend mocking - it can be done by using page.route or HAR files. It's more complicated, but it will make our tests more stable and performant and that's important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants