Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for 'about' youtube modal #990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YaelChen
Copy link
Collaborator

Description

I added a test that makes sure the YouTube modal can play,
but I had a problem with the HAR file.

It will probably not pass, but I need a place to discuss it in the PR comments section :)

@YaelChen YaelChen requested a review from NoamGaash as a code owner December 25, 2024 20:07
@YaelChen
Copy link
Collaborator Author

It worked when I ran in --debug mode, but failed without it.
-ui mode made me realize it was probably because of the HAR file,
I re-recorded it but it broke a bunch of other tests.
I didn't push the HAR, didn't really know what I broke there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant