code function to concatenate and manipulate strings

[noamoss]

The follwoing functions are example for a common need: manipulating strings (either from report record or user input) and to concatenate them into a single string, to be stored ina a report variable:

• combinedPoliceEventDescription,
• combinedEventDescription
• addMunicipalReaction

Since this is a returning need, as the current code tells us, and since the static texts added in the code level are not being translated (right?) I wondered if we should replace them with a function (cmd) to be called from the yaml/json script.

sunch function will have two parameters:

• list of strings: to combine into a single string
• the name of the record field in which we will save it.

note: building this function worth the efforts only if it enables to to combine field current text with a combination of a temporary variable and other static texts, like this:

new_description += `\n עדים או אנשים שיוכלו לאמת את הפרטים: \n${record._witness_details}`;
```

[akariv]

Yes, you could have a format function e.g.:

- do:
    cmd: format
    params:
    - record
    - target_field
    - format_string

Where format string would be able to use values from the record, e.g.
{{field1}}, {{field2}} and {{field3}}
or
- :field1\n- :field2\n- :field3

One note about the implementation though - I noticed that currently it always appends to the record, regardless of whether there already was a summary attached to it, creating very long values of repeated information.

Perhaps you could auto-add a separator (e.g. \n~~~~\n) which you'll use to mark the start of the automatic data, and when adding new data first delete whatever is after it before adding the new summary.

[noamoss]

Perhaps you could auto-add a separator (e.g. \n~~~~\n) which you'll use to mark the start of the automatic data, and when adding new data first delete whatever is after it before adding the new summary.

sounds good.

What is your time estimation for this task?

[akariv]

2hrs

…

On Thu, Oct 17, 2019, 15:32 noamoss ***@***.***> wrote: Perhaps you could auto-add a separator (e.g. \n~~~~\n) which you'll use to mark the start of the automatic data, and when adding new data first delete whatever is after it before adding the new summary. sounds good. What is your time estimation for this task? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#51?email_source=notifications&email_token=AACAY5KIJS5MJMTYIZUO5RTQPBLNFA5CNFSM4JBRCJF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBP5SXA#issuecomment-543152476>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACAY5JSJMFLWECTI455RV3QPBLNFANCNFSM4JBRCJFQ> .

[noamoss]

great, I think we should do it, as it is also a planned feature of the script editor (cc @oferb).

[noamoss]

please consider #52 when handling this issue.