Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PinStickiedDiscussionsToTop.php to fix a bug. #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lrysia
Copy link

@lrysia lrysia commented Feb 20, 2023

Fixed a bug: When browsing "All Discussions", if there are sticky/stickiest discussions, the SQL query results(for DiscussionList) sometimes do not meet expectations. It will cause one discussion to be ignored and one or more discussions to be displayed repeatedly.
If the description of the bug above is not clear enough, please watch this video I recorded: (https://youtu.be/vVlAkxUlIjg)

@YUCLing
Copy link

YUCLing commented Feb 25, 2023

I think you are requesting to pull too many edits you made for your repo.

Copy link

@YUCLing YUCLing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes you made here shouldn't be pulled to this repository. They were made for your repository.

@lrysia
Copy link
Author

lrysia commented Feb 27, 2023

I think you are requesting to pull too many edits you made for your repo.

Thank you for reminding me. I made a mistake when pulling.
I just want to pull the first commit.

@crazysvn
Copy link

thanks. this helped me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants