Moving to Python3 #313
Merged
Moving to Python3 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
requested changes
Jan 31, 2020
boxoffice/views/admin_item.py
Outdated
| @@ -9,7 +9,7 @@ | |||
| from boxoffice.models import db, Organization, ItemCollection, Item, Price | |||
| from boxoffice.views.utils import api_error, api_success, json_date_format | |||
| from boxoffice.forms import ItemForm, PriceForm | |||
There was a problem hiding this comment.
These imports have to change to ..
boxoffice/views/admin_order.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| from .. import app, lastuser | |||
| from coaster.views import load_models, render_with | |||
| from boxoffice.models import ItemCollection, Organization, Order, CURRENCY_SYMBOL, LineItem, LINE_ITEM_STATUS, ORDER_STATUS, INVOICE_STATUS | |||
There was a problem hiding this comment.
Could you correct from boxoffice imports across all files?
scripts/sync_razorpay_refunds.py
Outdated
| @@ -45,7 +45,7 @@ def sync_refunds(): | |||
| correspongding_rp_refund = min(possible_rp_refunds, | |||
| key=lambda rp_refund: abs(rp_refund['created_at'] - refund_epoch_dt)) | |||
| if not correspongding_rp_refund or amount_in_paise(refund.amount) != correspongding_rp_refund['amount']: | |||
| raise("Oops! No refund found for {refundid}.".format(refundid=refund.id)) | |||
| raise "Oops! No refund found for {refundid}." | |||
jace
reviewed
Jan 31, 2020
| @@ -12,7 +12,6 @@ install: | |||
| - pip install -U pip wheel | |||
| - pip install -r test_requirements.txt | |||
| - pip install -r requirements.txt | |||
| - pip install https://github.com/hasgeek/coaster/archive/master.zip | |||
There was a problem hiding this comment.
Doesn't this work if it's in requirements.txt?
There was a problem hiding this comment.
It should. I'm not sure why it was added here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to hasgeek/hgapp#39