Exception limit is too small for large binaries.

[jonomango]

bearparser/parser/pe/ExceptionDirWrapper.cpp

Line 4 in 6e0a817

uint64_t ExceptionDirWrapper::EntriesLimit = 10000;

I think that the current limit for exceptions is too small. Large binaries such as ntoskrnl.exe can have over 30,000 entries while bearparser will only parse the first 10,000. This really caught me off guard while using PE-Bear 😅. On a similar note, the number of entries is just DIRECTORY_SIZE / sizeof(ENTRY), so there shouldn't be a need to check for a null-terminator in here:

bearparser/parser/pe/ExceptionDirWrapper.cpp

Lines 29 to 32 in 6e0a817

	if (entry->getPtr() == NULL) {
	delete entry;
	break;
	}

...although it does make sense if you're expecting to deal with malformed binaries.

[hasherezade]

@jonomango - you are right, I was going to remove those limits, but then I forgot, sorry for this! it is gonna be fixed soon.

[hasherezade]

@jonomango - please check the new build (it is not the official release yet):

https://github.com/hasherezade/pe-bear-releases/releases/tag/0.5.5.4-rc2

[jonomango]

@hasherezade - Thanks for the quick response! I just tried it out and it works well. It does seem to slow down a bit when scrolling all the way to the bottom, but it's still usable.

[hasherezade]

@jonomango - the slowdown in scrolling is unfortunately a thing that cannot be avoided, it always happens when we try to display tables with many rows in Qt. It can be mitigated by introducing pagination. Maybe I will do it in the future, but from what I tested, this slowdown is not that significant to make this urgent.

[hasherezade]

@jonomango : the new release is ready: https://github.com/hasherezade/pe-bear-releases/releases/tag/0.5.5.4
thank you for your contribution!