Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI[Key]: Generate Node Gossip Keys #511

Closed
Tracked by #420
leninmehedy opened this issue Nov 10, 2023 · 4 comments · Fixed by #629
Closed
Tracked by #420

CLI[Key]: Generate Node Gossip Keys #511

leninmehedy opened this issue Nov 10, 2023 · 4 comments · Fixed by #629
Assignees
Labels
Milestone

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Nov 10, 2023

We need to generate *.pfx files containing multiple keys as done in hedera-node/data/keys/generate.sh.

It seems we can only do it in Java (or using keytool), not using openssl. Need to figure out if we can do it in Javascript.
Ref: https://stackoverflow.com/questions/51888110/how-to-make-pkcs12-pkcs12-contain-more-than-one-private-key-in-p12-container

Examples:

Seems we should use keytool to replicate the hedera-node/data/keys/generate.sh.

@github-project-automation github-project-automation bot moved this to 🆕 New in FST Suite Nov 10, 2023
@leninmehedy leninmehedy self-assigned this Nov 15, 2023
@leninmehedy leninmehedy moved this from 🆕 New to 🏗 In progress in FST Suite Nov 22, 2023
@leninmehedy leninmehedy moved this from 🏗 In progress to 🔖 Ready in FST Suite Nov 22, 2023
@leninmehedy
Copy link
Member Author

leninmehedy commented Dec 1, 2023

As discussed here, we may need to wait a bit to get support of separate pfx files for node-keys and certs as requested in this ticket: hiero-ledger/hiero-consensus-node#10211

We could use this library: https://github.com/digitalbazaar/forge#pkcs12

@leninmehedy leninmehedy added the Blocker Further development work cannot be done label Dec 1, 2023
@leninmehedy leninmehedy moved this from 🔖 Ready to ✋ Blocked in FST Suite Dec 1, 2023
@leninmehedy leninmehedy changed the title CLI[Chart]: Generate Node Gossip Keys CLI[Key]: Generate Node Gossip Keys Dec 1, 2023
@leninmehedy
Copy link
Member Author

I'm going to implement separate pfx files that will be compatible with future releases of the platform code.

@leninmehedy leninmehedy removed the Blocker Further development work cannot be done label Dec 8, 2023
@leninmehedy leninmehedy moved this from ✋ Blocked to 🏗 In progress in FST Suite Dec 8, 2023
@leninmehedy leninmehedy moved this from 🏗 In progress to ✋ Blocked in FST Suite Dec 18, 2023
@leninmehedy leninmehedy moved this from ✋ Blocked to 🏗 In progress in FST Suite Jan 5, 2024
@leninmehedy
Copy link
Member Author

Generating .pfx files seem to be tricky using nodeJS libraries. So we decided to generate PEM files instead

@leninmehedy leninmehedy moved this from 🏗 In progress to ✋ Blocked in FST Suite Jan 10, 2024
@nathanklick nathanklick added this to the v0.18.0 milestone Jan 22, 2024
@leninmehedy leninmehedy moved this from ✋ Blocked to 🏗 In progress in FST Suite Jan 29, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in FST Suite Feb 1, 2024
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants