Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): generate Gossip keys and gRPC TLS keys in PEM format #629

Merged
merged 86 commits into from
Feb 1, 2024
Merged

feat(cli): generate Gossip keys and gRPC TLS keys in PEM format #629

merged 86 commits into from
Feb 1, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Dec 12, 2023 •
edited
Loading

Description

This pull request changes the following:

  • generate node gossip keys and certs:
    • Signing key
      • s-private-<node ID>.key
      • s-public-<node ID>.cert
    • Agreement key
      • a-private-<node ID>.key
      • a-public-<node ID>.cert
    • gRPC TLS key
      • hedera-<node ID>.key [Renamed to hedera.key during node setup]
      • hedera-<node ID>.cert [Renamed to hedera.crt during node setup]
  • refactored cli prompts so that added input values persist
  • update key generation scripts so that user can use those to generate pfx and pem keys without solo

TODO

  • Fix e2e tests and ensure a node starts with the new key

Related Issues

@leninmehedy
add script and mock keys
f88d5ee 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
use latest generate.sh
bb387e5 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
feat(cli): generate pkcs12 formatted node signing key file using node…
e63db34 
…-forge library

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy linked an issue Dec 12, 2023 that may be closed by this pull request
CLI[Key]: Generate Node Gossip Keys #511
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Unit Test Results

  26 files  ±0    26 suites  ±0   55s ⏱️ -1s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 672c24e. ± Comparison against base commit a702e27.

♻️ This comment has been updated with latest results.

@leninmehedy
feat: generate private.pfx and public.pfx while generating signing ke…
0cbbe3e 
…y for a node

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
feat(cli): generate agreement and encryption key pfx files
56771ae 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
style: fix lint errors
5d61150 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: cleanup for consistency
cbb5bff 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
feat: create a script to generate keys using openssl
d476b47 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
doc: add comments
15b36f6 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
remove csr file after generating cert file
f6593aa 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
feat: update script to generate pfx files using openssl
22d786d 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
doc: update README for key generation script
dc0969c 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
remove test key files and update README
0004f97 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
no need to commit pfx files
294a330 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
update test
9c8d200 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: use ED25519 algorithm instead of EC for signed keys
4e1c766 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
attempt to use ed25519 for a-key and e-key
e0db506 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
save temporary works to pick up later
f53eae0 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
feat: generate keys and certs as PEM files
33079ef 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: verify cert after generation
438a5f6 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: use correct friendly name for signing key issuer and subject
7edbfb6 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
docs: update comment and cleanup
f4199e8 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: cleanup and add check
acf9b94 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
docs: update comment block
9093262 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
add debug logging
d187720 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
doc: update comment
b3291ad 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
remove unused node-forge
1800b9c 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
test: fix e2e tests
3de5443 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: address pr comments and cleanup
e5aa5d1 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
test: fix e2e tests
532735f 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: add validity arg and use EC algo for agreement keys
53ebbdd 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
test: add longer timeout for long running tests
cebf170 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
feat: select node root image based on platform version
1c01c64 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: align entrypoint script similar to previous node root images
bb7d604 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: ensure releaseTag has v prefix
264cd2d 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: checking for node ACTIVE status
612eb70 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix default release tag
6ca1379 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
test: increate timeout for long running test
9d51fc0 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy force-pushed the 511-generate-node-gossip-keys branch from ccc43a3 to 9d51fc0 Compare February 1, 2024 02:56
@leninmehedy
Merge branch 'main' into 511-generate-node-gossip-keys
34381b1
@leninmehedy
fix: codacy errors
02e3bd9 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
test: increate timeout correction
264d7fe 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: please codacy
250925c 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
fix: copy all PEM public keys for all nodes during node setup
672c24e 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

jeromy-cannon
jeromy-cannon approved these changes Feb 1, 2024
View reviewed changes
@jeromy-cannon jeromy-cannon merged commit d970796 into main Feb 1, 2024
18 of 20 checks passed
@jeromy-cannon jeromy-cannon deleted the 511-generate-node-gossip-keys branch February 1, 2024 15:23
swirlds-automation added a commit that referenced this pull request Feb 5, 2024
@swirlds-automation
chore(release): 0.20.0 [skip ci]
e81fd90 
## [0.20.0](v0.19.1...v0.20.0) (2024-02-05)

### Features

* **cli:** allow deploying different number network nodes ([#726](#726)) ([410d499](410d499))
* **cli:** generate Gossip keys and gRPC TLS keys in PEM format ([#629](#629)) ([d970796](d970796))

### Bug Fixes

* update solo readme with examples ([#725](#725)) ([dd8bbd7](dd8bbd7))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@nathanklick nathanklick Awaiting requested review from nathanklick

Assignees

@leninmehedy leninmehedy

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI[Key]: Generate Node TLS Keys CLI[Key]: Generate Node Gossip Keys
3 participants
@leninmehedy @swirlds-automation @jeromy-cannon