Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repo Maintainers to CODEOWNERS file #4462

Open
andrewb1269hg opened this issue Dec 9, 2024 · 3 comments
Open

Add Repo Maintainers to CODEOWNERS file #4462

andrewb1269hg opened this issue Dec 9, 2024 · 3 comments
Assignees

Comments

@andrewb1269hg
Copy link

Update CODEOWNERS to provide maintainers ownership of all files in their repos

Description:

Update this repositories .github/CODEOWNER file to ensure that the repository maintainer
group(s) have full control of the files in this repository.

@rbarkerSL
Copy link
Contributor

rbarkerSL commented Dec 9, 2024

The CODEOWNERS file should be freely updated by @hashgraph/envision-blockchain-hedera with the following caveats:

###################################
##### Global Protection Rule ######
###################################
# NOTE: This rule is overriden by the more specific rules below. This is the catch-all rule for all files not covered by the more specific rules below.
*                                               @hashgraph/envision-blockchain-hedera # add teams as desired

.........


#########################
#####  Core Files  ######
#########################

# NOTE: Must be placed last to ensure enforcement over all other rules

# Protection Rules for Github Configuration Files and Actions Workflows
/.github/                                       @hashgraph/devops-ci @hashgraph/devops-ci-committers # add teams as desired
/.github/workflows/                             @hashgraph/devops-ci @hashgraph/devops-ci-committers # add teams as desired

# NodeJS project files
package.json                                    @hashgraph/devops-ci @hashgraph/devops-ci-committers # add teams as desired
package-lock.json                               @hashgraph/devops-ci @hashgraph/devops-ci-committers # add teams as desired
jest.config.mjs                                 @hashgraph/devops-ci @hashgraph/devops-ci-committers # add teams as desired

# Codacy Tool Configurations
/config/                                        # add appropriate teams
.remarkrc                                       # add appropriate teams

# Semantic Release Configuration
.releaserc                                      @hashgraph/devops-ci @hashgraph/devops-ci-committers # add teams as desired

# Self-protection for root CODEOWNERS files (this file should not exist and should definitely require approval)
/CODEOWNERS                                     @hashgraph/release-engineering-managers # No modifications

# Protect the repository root files
/README.md                                      # add appropriate teams
**/LICENSE                                      @hashgraph/envision-blockchain-hedera  # add teams as desired

# CodeCov configuration
**/codecov.yml                                  @hashgraph/devops-ci # add teams as desired

# Git Ignore definitions
**/.gitignore                                   # add appropriate teams
**/.gitignore.*                                 # add appropriate teams

Note that the Core Files section and the catch-all at the top are the only two required sections in a Hashgraph repository. Ownership is determined top-to-bottom in the CODEOWNERS file. Meaning if there is a rule at line 100 in the file and a conflicting rule at line 10 in the file; the rule at line 100 would take precedence.

anvabr added a commit that referenced this issue Dec 12, 2024
As requested in #4462

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>
@anvabr
Copy link
Collaborator

anvabr commented Dec 12, 2024

@rbarkerSL Could you please take a look at the #4471 - does the update aligns with Hashgraph policies?

@rbarkerSL
Copy link
Contributor

@anvabr I added some comments to correct minor issues in how the teams were added in.

anvabr added a commit that referenced this issue Dec 13, 2024
* Update CODEOWNERS #4462

As requested in #4462

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update CODEOWNERS

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

---------

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>
Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
simvalery pushed a commit that referenced this issue Dec 17, 2024
* Update CODEOWNERS #4462

As requested in #4462

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

* Update CODEOWNERS

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>

---------

Signed-off-by: Andrey (Envision) <32775532+anvabr@users.noreply.github.com>
Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants