-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move Foundry project to repo root #103
Conversation
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
.github/workflows/test.yml
@arianejasuwienas could you explain why? Keep in mind this is not an architectural change, only a refactor. |
@acuarica after moving @hts-fork foundry.toml to the parent directory I won't be able to reference it as a library. I'm not sure why, but when I have a structure like:
And I try to include the code from parent as a library in the children (libs = [".."]) then it ends up in the infinite loop of dependencies.
The problem does not occur for previous structure:
libs = ["../children2"] |
The idea is to have both solutions under a single Foundry project, not two. See #101 for reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR moves the Foundry project from the
@hts-forking
into the repo root. This will allow us to have both Hardhat and Foundry solution within the same Foundry project.Related issue(s):
Fixes #102.
Notes for reviewer:
Important
We use a symbolic link
@hts-forking/resources/HtsSystemContract.json
to the compilation output of HTS. This allow us to modify the HTS contract and test the npm package without and intermediate step to copy the compilation output.It's is important that all
require
s within the npm package are inside the@hts-forking
folder, so when we publish it all files are contained.Note
To commit symbolic links that are processed by
prettier
, e.g., json files, I had to temporarily disableprettier
. Otherwise, I got the errorLooks like
prettier
does not support symbolic links.Checklist